An event after survey validate the questions on the current page is missed

Are you requesting a feature, reporting a bug or asking a question?

I’m reporting a bug.

What is the current behavior?

Accessing surveyModel.isCurrentPageHasErrors will cause onErrorCustomText events to be fired for each error on the page.

What is the expected behavior?

The documentation says that isCurrentPageHasErrors is a readonly property. I would expect that accessing a property doesn’t fire events, potentially triggering side-effects that I’ve added to these events.

How would you reproduce the current behavior (if this is a bug)?

Add a console.log to onErrorCustomText and then access isCurrentPageHasErrors from any event such as onAfterRenderSurvey.

Provide the test code and the tested page URL (if applicable)

Run the below code and open the console.

If there are two questions on the first page of the survey, onErrorCustomText will fire twice.

Test code

import React from 'react';
import { Model, Survey } from 'survey-react';
import { mockData } from '../lib/mockData';

export class SurveyTest extends React.Component {
    public render() {
        return <Survey 
            json={mockData} 
            onErrorCustomText={this.onErrorCustomText} 
            onAfterRenderSurvey={this.onAfterRenderSurvey}
        />
    }

    private onErrorCustomText = () => {
        console.log('onErrorCustomText');
    };

    private onAfterRenderSurvey = (s: typeof Model) => {
        s.isCurrentPageHasErrors;
    }
}

Specify your

• browser: Chrome
• browser version: 73.0.3683.103 (Official Build) (64-bit)
• surveyjs platform (angular or react or jquery or knockout or vue): react
• surveyjs version: 1.0.78

[andrewtelnov]

@zhihil I have a new event, onValidatedErrorsOnCurrentPage. It fires after question validation on the current page. You may look at my unit test to find out how it works.

It will be available in the next minor update, that we will release on the next week. You may build the library from source. The instruction for building library from source in the Readme file.

Let me know if it works.

Thank you, Andrew

[andrewtelnov]

Great!