`handle` can run when endpoint functions are not exported

Describe the bug

Empty .js or .ts file that does not export any endpoint functions (eg. GET) can still trigger handle.

Reproduction

Used create-svelte@2.0.0-next.149 and SvelteKit demo app template.

Prerequisite

Log request method and pathname in the beginning of the handle function.

export const handle: Handle = async ({ event, resolve }) => {
	const { request: { method }, url: { pathname } } = event;
	console.log(method, pathname);
...

Control Group

Run vite dev, open /, then navigate to /about.

  VITE v3.0.2  ready in 205 ms

  ➜  Local:   http://localhost:5174/
  ➜  Network: use --host to expose

GET /

Experimental Group

Create a blank about.ts file alongside about.svelte

├── __layout.svelte
├── about.svelte
├── about.ts // Created
├── index.svelte
└── todos
    ├── _api.ts
    ├── index.svelte
    └── index.ts

Run vite dev, open /, then navigate to /about.

  VITE v3.0.2  ready in 199 ms

  ➜  Local:   http://localhost:5174/
  ➜  Network: use --host to expose

GET /
GET /about

GET /about is logged in the experimental group only.

System Info

System:
  OS: macOS 12.4
  CPU: (8) arm64 Apple M1
  Memory: 92.70 MB / 8.00 GB
  Shell: 5.8.1 - /bin/zsh
Binaries:
  Node: 16.14.2 - ~/.nvm/versions/node/v16.14.2/bin/node
  npm: 8.5.0 - ~/.nvm/versions/node/v16.14.2/bin/npm
Browsers:
  Chrome: 103.0.5060.134
  Firefox: 102.0
  Safari: 15.5

Severity

annoyance

[tcc-sejohnson]

I was expecting Page Endpoint requests only when there is a matching request handler function.

The client has no idea what functions are exported from the server AFAIK. The existence of a matching .ts file determines whether the page gets built with a page endpoint.

Since there is no GET request handler exported from the about.ts (experimental group), I was expecting a client-side navigation, just like in the control group. (when opening / and then navigating to /about)

You are getting client-side navigation. It’s just that your page is making a fetch request to its page endpoint for data because you put a matching .ts file in there. That fetch request is what’s triggering handle.

Opening /about directly or hard reloading the page does log GET /about in both cases.

Yep, expected.

TL;DR: Don’t create a matching .ts file if you don’t want your page to try to fetch from its page endpoint.

[hyunbinseo]

Creating a .ts file that starts with an underscore does not generate a RequestHandler type.

Since this file is for utility purpose only, I guess I should convert it into a standalone endpoint.

Thank you once again.