Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Meta duplicate

See original GitHub issue

Describe the bug

Meta duplicate is back

Reproduction

https://github.com/thousandsofraccoons/double-meta

Logs

No response

System Info

System:
    OS: Windows 10 10.0.19043
    CPU: (8) x64 Intel(R) Core(TM) i7-10510U CPU @ 1.80GHz
    Memory: 2.39 GB / 15.87 GB
  Binaries:
    Node: 16.0.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.10 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 7.10.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.19041.1266.0), Chromium (107.0.1418.26)
    Internet Explorer: 11.0.19041.1566
  npmPackages:
    @sveltejs/adapter-auto: next => 1.0.0-next.86
    @sveltejs/adapter-vercel: ^1.0.0-next.81 => 1.0.0-next.81
    @sveltejs/kit: next => 1.0.0-next.532
    svelte: ^3.46.0 => 3.52.0
    vite: ^3.1.0 => 3.2.2

Severity

serious, but I can work around it

Additional Information

No response

Issue Analytics

State:
Created a year ago
Comments:11 (8 by maintainers)

Top GitHub Comments

1reaction

dummdidummcommented, Nov 7, 2022

If you pre-rendered static site ships without any JavaScript (export const csr = false) and therefore hydration isn’t needed, then you can turn it on. Good point about the example, will update the docs.

0reactions

zerodevxcommented, Nov 7, 2022

The suggested html-minifier config in the svelte-kit docs include removeComments: true so should that be corrected? Or perhaps there’s a whitelist of patterns that minifier should ignore?

It’s not clear from the docs that HTML comment nodes are required for hydration - or any other functions.

Lastly, does this also apply if the project is built as a pre-rendered static site - where html-minifier is run not as a hook but as a post-build task?