Tests are not running

Describe the bug

It looks like our browser tests are not running

This would explain recent regressions (e.g. https://github.com/sveltejs/kit/issues/2041)

I’m hesitant to merge any PRs until this gets fixed. I’ve added a note to the PR template informing PR submitters of this

Help looking into this issue would be appreciated

Reproduction

If I make the first line throw new Error('this should fail'); the test suite still passes

https://github.com/sveltejs/kit/blob/459efa27a8af5ad51d2a2c3aa8932f91344492cf/packages/kit/test/apps/basics/src/routes/routing/_tests.js#L205

Logs

No response

System Info

`master`

Severity

blocking an upgrade

Additional Information

No response

[benmccann]

I just changed it locally back to:

		"dev": "svelte-kit dev",
		"build": "svelte-kit build",
		"preview": "svelte-kit preview"

It doesn’t look like it changes anything. I changed a test so that it should fail and I’m still not seeing any test failures

The reason for changing was so that I could run the test projects myself with pnpm run dev and see what the tests were seeing. I added a line to the readme describing this:

You can run the test server with cd packages/kit/test/apps/basics; pnpm run dev to hit it with your browser.

I think the path is correct as is since the following works:

cd packages/kit/test/apps/basics/
ls ../../../svelte-kit.js

[sebastianrothe]

I also have idea, we should probably set in workflow, that skipped tests must be = 0.

It would be a good idea to use eslint-plugin-jest and enforce the linting in the CI. The plugin does not allow skipping or restricting tests.