"TypeError: Request3 is not a constructor" upgrading `adapter-netlify` from 76 to 77 - Resolved: esbuild does not work on Netlify, do not enable in netlify.toml or use netlify edge

Describe the bug

I upgraded my SK version from 510 to 561 and adapter from 72 to 89 (https://github.com/sw-yx/swyxkit/commit/ffdd14921ed058961d1b638735077fb26bbf8385) and it started reporting a TypeError: Request3 is not a constructor error:

(you can see the preview here https://app.netlify.com/sites/swyxkit/functions/render?scope=deploypreview:136) causing all renders to 500.

this doesnt happen in dev, only prod.

Reproduction

https://github.com/sw-yx/swyxkit/commit/ffdd14921ed058961d1b638735077fb26bbf8385

i am debugging in https://github.com/sw-yx/swyxkit/pull/136

Logs

Nov 28, 12:38:24 PM: b5dfe38e ERROR  TypeError: Request3 is not a constructor
    at file:///var/task/.netlify/functions-internal/render.mjs:24273:22
    at new Promise (<anonymous>)
    at fetch3 (file:///var/task/.netlify/functions-internal/render.mjs:24272:10)
    at listContent (file:///var/task/.netlify/functions-internal/render.mjs:36534:23)
    at GET2 (file:///var/task/.netlify/functions-internal/render.mjs:36737:23)
    at render_endpoint (file:///var/task/.netlify/functions-internal/render.mjs:44730:29)
    at resolve (file:///var/task/.netlify/functions-internal/render.mjs:46610:29)
    at async respond (file:///var/task/.netlify/functions-internal/render.mjs:46520:23)
    at async fetch (file:///var/task/.netlify/functions-internal/render.mjs:46370:21)
    at async Object.fetch (file:///var/task/.netlify/functions-internal/render.mjs:46302:12)

System Info

"@histoire/plugin-svelte": "^0.11.7",
		"@playwright/test": "^1.28.1",
		"@sveltejs/adapter-auto": "1.0.0-next.89",
		"@sveltejs/kit": "^1.0.0-next.561",
		"@tailwindcss/typography": "^0.5.8",
		"@typescript-eslint/eslint-plugin": "^5.44.0",
		"@typescript-eslint/parser": "^5.44.0",
		"autoprefixer": "^10.4.13",
		"concurrently": "^7.6.0",
		"eslint": "^8.28.0",

Severity

annoyance

Additional Information

filing for others to find in future as i try to isolate the problem.

i am debugging in https://github.com/sw-yx/swyxkit/pull/136

[benmccann]

The reason it’s using esbuild is this line:

https://github.com/sw-yx/swyxkit/blob/ffdd14921ed058961d1b638735077fb26bbf8385/netlify.toml#L8

I recommend you remove that if you’re having difficulty with esbuild. adatper-netlify will only use esbuild if you either set that option in netlify.toml or set edge: true in the adapter options

[sw-yx]

ahh thanks. its not yet 100% working for me (https://deploy-preview-138--swyxkit.netlify.app/welcome is mysteriously 404ing) but still pretty good! thank you!