Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Validate `handle` response

See original GitHub issue

Describe the bug

I upgraded the adapter-node and kit, and changed the hooks to reflect new syntax from https://github.com/sveltejs/kit/pull/3384 and now the server crashes when started with the exit code in log

Reproduction

https://github.com/PH4NTOMiki/sveltekit-book

Logs

file:///home/mutic/dev/sveltekit-book/node_modules/@sveltejs/kit/dist/node.js:64
        res.writeHead(response.status, Object.fromEntries(response.headers));
                                              ^

TypeError: object is not iterable (cannot read property Symbol(Symbol.iterator))
    at Function.fromEntries (<anonymous>)
    at setResponse (file:///home/mutic/dev/sveltekit-book/node_modules/@sveltejs/kit/dist/node.js:64:40)
    at file:///home/mutic/dev/sveltekit-book/node_modules/@sveltejs/kit/dist/chunks/index.js:2083:8
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

Node.js v17.2.0

System Info

System:
    OS: Linux 5.13 Manjaro Linux
    CPU: (8) x64 Intel(R) Core(TM) i5-8265U CPU @ 1.60GHz
    Memory: 1.28 GB / 7.65 GB
    Container: Yes
    Shell: 5.1.12 - /bin/bash
  Binaries:
    Node: 17.2.0 - /usr/local/bin/node
    npm: 8.1.4 - /usr/bin/npm
  Browsers:
    Firefox: 95.0.1
  npmPackages:
    @sveltejs/adapter-node: ^1.0.0-next.66 => 1.0.0-next.66 
    @sveltejs/kit: ^1.0.0-next.236 => 1.0.0-next.236 
    svelte: ^3.44.3 => 3.44.3

Severity

blocking an upgrade

Additional Information

Everything was working without any issue before update.

Issue Analytics

State:
Created 2 years ago
Comments:12 (11 by maintainers)

Top GitHub Comments

1reaction

gterrascommented, Jan 22, 2022

I met the same error, for those searching for a fix I had to change :

export const handle = async ({ event, resolve }) => {
	if (condition) 
		return LoginPage
}

const LoginPage = {
	status: 200,
	headers: {
		'content-type': 'text/html',
		'cache-Control': 'private, max-age=0, no-cache',
	},
	body: '<html>...</html>',
}

to :

const LoginPage = () => new Response('<html>...</html>', {
	status: 200,
	headers: {
		'content-type': 'text/html',
		'cache-Control': 'private, max-age=0, no-cache',
	}
})

0reactions

PH4NTOMikicommented, Jan 21, 2022

Yeah, you are right, actually I figured out that myself a few minutes ago and fixed it with a commit https://github.com/PH4NTOMiki/sveltekit-book/commit/e673854ab7f550e7bf3ff7ab87481e9f7b2a7259 to my repo, it was leftover from the previous version, and it was in a conditional that rarely comes true(it was only when the user is logged out and tried to access the API route) and when I figured out that it errors only when I’m logged-out and I knew where to look