question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Breaking change regarding symlinks in latest release

See original GitHub issue

Updating to the latest release is breaking my build: https://circleci.com/gh/fimbullinter/wotan/11618

It seems that symlinks are resolved before looking up the package in package.json.

packages/bifrost/src/index.js imports from @fimbul/ymir where node_modules/@fimbul/ymir is a symlink to packages/ymir.

Before: packages/bifrost/src/index.js → node_modules/@fimbul/ymir/src/index.js Now: packages/bifrost/src/index.js → packages/ymir/src/index.js

Therefore I now get tons of error no-non-package-json

I guess this is caused by your recent switch to pnp to resolve dependencies.

Steps to Reproduce (for bugs)

  1. check out https://github.com/fimbullinter/wotan/commit/176571ee83120a2720f6ac7bc9d6cb9b0d0fc0a3
  2. yarn
  3. yarn check-dependencies

Your Environment

  • Version used: 4.15.0 (before 4.14.0)
  • Node version: 10 LTS
  • Operating System and version: Ubuntu?
  • Link to your project: see above

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
ajafffcommented, Mar 18, 2019

Everything worked fine on 4.14.0

0reactions
sverweijcommented, Mar 22, 2019

I’ve published v4.15.1 to npm - thanks for raising this issue!

Read more comments on GitHub >

github_iconTop Results From Across the Web

NET 7 breaking change: Time fields on symbolic links
When changes are made to the following time-related fields on a symbolic link ("symlink"), the updates now affect the symlink itself and not...
Read more >
3.2. Data integrity - The DataLad Handbook
Whenever a symlink points to a non-existent target, this symlink is called broken, and opening the symlink would not work as it does...
Read more >
Using yarn symlinks to share code between apps
Using yarn symlinks to share code between apps. If you're working on multiple apps and you want to share code between them -...
Read more >
How to Create Symbolic Links: A Comprehensive Guide
Create a symbolic link using the below syntax. This command creates the symlink in the current directory. ... Change symlink_name to your desired ......
Read more >
How are Windows symbolic links treated by the apps?
Symlinks are transparent to applications that are using the underlying file system, e.g., CreateFile() and friends, unless the application ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found