Incorrect validation message for unique operationId

Q	A
Bug or feature request?	Bug
Which Swagger/OpenAPI version?	2
Which Swagger-Editor version?	3.2.4
How did you install Swagger-Editor?	Using swagger-editor-dist with express, also reproducible in editor.swagger.io
Which broswer & version?	Latest Chrome
Which operating system?	Windows

Demonstration API definition

swagger: '2.0'
info:
  version: v3
  title: test
basePath: /v1
paths:
  /:
    post:
      responses:
        200:
          description: Successful response
    get:
      operationId: myId2
      responses:
        200:
          description: Successful response

Expected Behavior

No validation error

Current Behavior

Semantic error at paths./.get.operationId Operations must have unique operationIds. Jump to line 13

Possible Solution

Added some logging to src/plugins/validate-semantic/validators/operations.js shows that __originalOperationId for both methods are set to “myId2”

Probably caused by this line? https://github.com/swagger-api/swagger-js/blob/master/src/helpers.js#L161

Test to be added to catch the bug

Add the following test to test/plugins/validate-semantic/operations.js

    it("should not return an error when only some operationId is defined without collisions", () => {
      const spec = {
        paths: {
          "/": {
            get: {
            },
            post: {
              operationId: "myId2"
            }
          }
        }
      }

      return expectNoErrors(spec)
    })

[shockey]

@jemerald we held off on a Swagger-Editor release last Friday since it (a) had a special release last Wednesday, and (b) has no new source changes since v3.2.5.

We will cut a new release on Friday that includes the updated Swagger-Client version. If this is severely impacting your workflow, just let me know and I can run a release to get this out faster.

[jemerald]

@rahulsaini the operationId has nothing to do with the path of your API.

See https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md#operation-object

For what you want to achieve, you need to put it into the path, e,g. /searchdynamic/substtype/getModifiedTerms: