Relative $refs aren't relative to the file in which they are declared.

Description

Relative $ref declarations don’t resolve relative to their containing file.

For example

main.yaml
  - models
    - model1.yaml
  - common
    - shared.yaml

Assume a reference in model1.yaml like $ref: '../common/shared.yaml#/definitions/MyObj'

This will fail via an Unable to load RELATIVE ref: ... error (via the codegen).

The ResolverCache resolves these references relative to a parentDirectory file that is final:

https://github.com/swagger-api/swagger-parser/blob/64a5ea7402183fc4cd8a1b58602045952311e0da/modules/swagger-parser/src/main/java/io/swagger/parser/ResolverCache.java#L113

Wouldn’t the parentDirectory need to be variable - i.e., be set to the directory containing the file where the $ref is declared?

[CluEleSsUK]

I’m experiencing this same issue with version 2.3.1, but neitherupgrading the swagger parser to 1.0.34 nor 1.0.35-SNAPSHOT fixes it for me, however 1.0.44 does! Sorry to necro this, but might be useful to others

[sotty]

I could use 1.0.34 to parse a graph of mutually referencing models successfully Kevin took it one step further with the code generation, but had to use 1.0.35-SNAPSHOT

We did not have the time to isolate which commit(s) did fix the problem

Thanks for your assistance!

On Mon, Apr 16, 2018 at 2:43 PM, Kevin Peterson [e-mail] wrote:

I used 1.0.35-SNAPSHOT and that seemed to take care of the problem. Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/swagger-api/swagger-parser/issues/671#issuecomment-381725153, or mute the thread https://github.com/notifications/unsubscribe-auth/AAf0OnIb-WPxegf3xoLcrrk7yp2VdgXBks5tpPRFgaJpZM4TFt5S .