Add parameters to define width and height for modal

How to define variable width/height for modal? Looks like it can’t calculate things properly it these are used. Eg.: width: '50%' , width: '5vw' etc.

Furthermore, I think max-width and max-height are also important to have, especially for images.

[acupofjose]

@limonte I can think of a few use cases. With the additional parameters and event bindings that swal2 supports now, it’s becoming more than just a dialog modal. You could use swal2 to display videos or dynamic content, videos, iframes, images, etc. that it could be useful to have sized to a specific standard.

I do realize these use cases go beyond what the original use cases for what swal and swal2 were, but I don’t necessarily think that’s a bad thing.

Thoughts?

[Rikk]

Important for mobile, fixed-widths usually will be cut on small screens. And having no overflow: auto, user can’t scroll modal contents using scrollbar, when contents are large; for example, a large image or an image with imageWidth set too high. A good ability for a popup is to automatically adapt itself to the environment it is present, even if it is unknown. I see swal2 (maybe also original swal) uses margin-left and a px value for width to calculate its position…

modal.style.width = params.width + 'px';
modal.style.marginLeft = -params.width / 2 + 'px';

Instead, why doesn’t it calculate window.width, get its own width, then find the center? And because it is position: fixed, maybe top and left values are the only things it needs to calculate for positioning itself. I think the title you set for this issue is not really accurate, while we can’t define height we can already define width, but as fixed pixels.