Calling swal.close() does not call the onClose callback

Calling swal.close() does not call the onClose callback. It does work, though, when calling swal.clickCancel().

swal({
	onClose: () => {
		console.log('not being called');
	}
});

if (swal.isVisible()) {
	swal.close();
}

https://jsfiddle.net/ad3quksn/436/

[rkyoku]

IMHO, it should always provide an information regarding what triggered it (cancel button, close button, click on overlay, validation, whatever).

It does not cost anything (I think) to do it, and it provides information that may be of value in some cases.

What do you think?

[zenflow]

@RenaudParis Thanks for opening this issue, with reproduction

Hmm. Yeah, that behavior seems wrong.

We should probably restrain from fixing it in this major though, since it’s a breaking change and might cause issues in some projects.

As a temporary workaround, maybe use swal.clickConfirm or swal.clickCancel instead of swal.close. You can use those even if the buttons aren’t visible.

Slightly off-topic Open question - What would you expect to happen with the current swal’s Promise when you use swal.close? Currently it’s left in a pending state.