Cancel button calls resolve
See original GitHub issueIn the ‘Are you sure?’ examples, the cancel button should call reject
, not resolve
(Proper promise syntax, I think)
Issue Analytics
- State:
- Created 7 years ago
- Reactions:1
- Comments:12 (6 by maintainers)
Top Results From Across the Web
Call cancel button - Power Platform Community - Microsoft
Solved: Hi guys! I have an app where users make requests for data changes to the system. This app feeds a list to...
Read more >How to create a HTML Cancel button that redirects to a URL
Run code snippet ... Assign type="button" to the cancel button within a form, then; set a href="/wherever_page_needs_to_go" attribute (alt tags, titles, ...
Read more >Enable Resolve and Cancel Button in Portal : r/servicenow
Enable Resolve and Cancel Button in Portal. Hi guys, is there and OOB option that i can enable so user can cancel or...
Read more >Promise.all() - JavaScript - MDN Web Docs
The Promise.all() method takes an iterable of promises as input and returns a single Promise. This returned promise fulfills when all of the ......
Read more >Power button ends call - Android Accessibility Help
Open your device's Settings app . Tap Accessibility. Turn on Power button ends call.
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Thank you @AmitMY for standing for you point, I probably have to agree with you and make this breaking change 😃
Please give your opinion about this structure:
cc @samturrell @Tonkpils @jdcrensh
In my opinion, because all do the same action, they should do
reject()
That way, if there is a promise in the SWAL, and it rejects, it will normallyreject(error)
, such that you can handle by checkingif(error)
And if not, and the promise sends reject() it means just ‘close’ - no nead for error handling.This removes the check
if(isConfirm)
, and uses the build in promise rejectionWhat do you think? Where am I logically failing?