Types: DismissReason enum

Current behavior

When a SweetAlertResult is returned with a DismissReason, the dismiss reason is a string. However, the Swal.DismissReason type is a standard typescript enum, implying that it will be a number

Expected behavior

The Swal.DismissReason enum declaration would be a string enum

enum DismissReason {
  cancel = 'cancel',
  backdrop = 'backdrop',
  close = 'close',
  esc = 'esc',
  timer = 'timer'
}

Live demo

https://tasteful-spectrum.glitch.me

[Basaingeal]

Alright. Thanks for the information. I ran some tests using the declaration file, and you’re right, the evaluations work out.

I’m working on a library that needs to serialize these results to JSON strings, so some of my type conversions were not going as expected, but I think I can sort it out now based on the information provided.

Thank you.

[toverux]

Would not dismiss == Swal.DismissReason.cancel be transpiled to dismiss == 0 which would evaluate to false?

No, don’t worry, .d.ts files never have any kind of influence on the emitted code. The enum itself and its values are always coming from the SweetAlert source, that is JavaScript. A .d.ts file cannot bear any actual value that can be used at runtime. That’s pure types.

Also, I don’t mean to doubt you, but just changing the enum to a string enum in the sweetalert2.d.ts seems to work fine for me.

That is possible, however (that’d still be types… no matter what values you put in the enum members, at runtime that’ll still be what SweetAlert declared). I said that by memory, so I’m not sure, you may be right. In that case that would fix comparison with simple strings.