Use defaults for undefined arguments in shorthand call to swal

I found some unexpected behavior when working on #979…

jsfiddle

main()
async function main () {
  swal.setDefaults({type: 'question'})
  await swal({ title: 'I am the question type...'})
  await swal('but I am not?')
}

I would expect the second swal to also have type of 'question', but it does not.

It’s due to this line of code, which assigns the values to params even when they are undefined…

https://github.com/sweetalert2/sweetalert2/blob/13d90857418f69094c7c259596323cd510b6c970/src/sweetalert2.js#L104

I propose that we treat undefined arguments as such, and use the parameter defaults in these cases. What do y’all think?

I’m not sure if this would be considered a fix or a breaking change. I mean, I’m pretty sure it’s technically a breaking change, but bug fixes usually are. How likely is it that people are relying on the current behavior?

[zenflow]

Bug-fix IMO.

Good. Yeah I agree.

I was thinking of something like this:

function argsToParams(args) {
  const params = {}
  ;['title', 'html', 'type'].forEach((name, index) => {
    if (args[index] !== undefined) {
      params[name] = args[index]
    }
  })
  return params
}

I’ll put in another PR after #992 settles

[toverux]

Aha, it’s amusing to see that we always agree on complex subjects and general direction but always fail to find a compromise on the smallest details 😆

I don’t see how it is complex.

I don’t feel comfortable copy-pasting code for the sake of reducing function calls.

It’s not code duplication at this point 😃 You are a bit extreme here. It’s just a small, pure-JS pattern applied to three variables. Our brain likes those visual layouts and patterns. Those LoCs don’t need to be fully read, parsed and analyzed. At the contrary, the array, the function, the loop, the array access syntax, the if branch, the two levels of indentation: they make this code look complicated. I need to read those lines when scanning the code. It’s all about cognitive load (athough the performance is also reduced, but I agree it’s not that relevant here).

But don’t worry, I’m not asking you to change it if you don’t agree, I don’t care that much about that. I’m just saying that I would have not written it like that. And I’m sorry to have started another unproductive debate 😄