Class and Namespace Name Collision

Main class and namespace in which it is declared share the same name.

namespace Spectrogram
{
    public class Spectrogram
    {
...

This causes some inconvenience when creating an instance.

using Spectrogram;

var spec = new Spectrogram(...);
// CS0118: 'Spectrogram' is a namespace but is used like a type

I know this is a breaking change, but have you considered changing the namespace’s name?

[swharden]

Thanks again for raising this issue @lawrence-laz! I ended-up changing it to SpectrogramGenerator, updated all the documentation, and released version 1.3.0 on NuGet 👍

[swharden]

name SGram however strikes as a bit odd and cryptic

name SpectrogramGenerator seemed a bit better

I think I agree with you here!

// this is shorter, but cryptic
var sg = new SGram(sampleRate, fftSize: 4096, stepSize: 500, maxFreq: 3000);
sg.Add(myData);
sg.SaveImage("data.png");

// this is more to type, but more expressive
var sg = new SpectrogramGenerator(sampleRate, fftSize: 4096, stepSize: 500, maxFreq: 3000);
sg.Add(myData);
sg.SaveImage("data.png");

Expressiveness and readability should be favored over character count…

I’ll sleep on this one for a day or two and come back with fresh eyes before I make a final call! Thanks again for pointing it out @lawrence-laz. I’ll leave this issue open until I fix it and the new package is in NuGet