Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Feature Request: Allow adding % to tooltips

See original GitHub issue

I’m submitting a … (check one with “x”)

[ ] bug report => search github for a similar issue or PR before submitting
[x] feature request
[ ] support request => Please do not submit support request here

Expected behavior I have formatted my data to be in the form of % insteazd of absolute values. It would be nice if all charts had an @Input() percentage : boolean. It would default to false but if made True, it would add a % following the value on the tooltip.

What is the motivation / use case for changing the behavior? Many people like to use relative numbers instead of absolute numbers, I think it would it would be a valuable feature for myself and other users.

I would submit a pull request, but I cannot find where the templates for the tooltips are defined. If someone would kindly point out where they are, I would gladly have a go at implementing this.

Issue Analytics

State:
Created 6 years ago
Comments:18 (13 by maintainers)

Top GitHub Comments

2reactions

JoshSchoencommented, Apr 12, 2017

Ideally it would be across all charts as you could show $ or % in most any of the available charts. The big ones currently are pie chart, stacked vertical and horizontal bar for our current use case. But I could see trend line charts as well in the immediate future. I like the idea of a custom formatter but not sure what that means exactly. For both % and $ I think it is also worth noting that the input value should be defined as a decimal for rounding and conversion to a % value or set an expectation that the values from the data are in a format where all that needs to happen is a prepend of $ or append a %. The latter of the two might be a simpler implementation but not as flexible and probably not great for different currencies . There has also been some thoughts around adding text for annotations and threshold type formatting in tooltips but that is probably a different issue. Please let me know how I can help, happy to pitch in here.

Side note, really enjoying working with NGX charts some really great work!

1reaction

JoshSchoencommented, May 10, 2017

@Hypercubed I’m sure you guys have a lot of other Priorities but wondering when #369 might be reviewed? Appreciate any info you have on this.