Is Chart using available space properly in responsive mode

I’m submitting a … (check one with “x”)

[ x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here

Current behavior Charts in responsive mode (no view set) not using up available parent space (Marjan asked to raise from gitter)

Expected behavior Charts would use up more of the available space

Reproduction of the problem

<div class="col-12"> <div class="card"> <div class="card-header"> State Of The Parties </div> <div class="card-block" style="min-height: 400px;width:100%"> <ngx-charts-pie-chart [scheme]="colorScheme" [results]="partyTotals" [legend]="false" [explodeSlices]="false" [labels]="true" [doughnut]="false" [gradient]="gradient" (select)="onSelect($event)"> </ngx-charts-pie-chart> </div> </div> </div>

What is the motivation / use case for changing the behavior? Charts would be better responsive if they used the space available better on smaller viewports

Windows 10

• ngx-charts version: 4.1.2
• Angular version: 2.4.7
• Browser: all

[StanFisher]

@marjan-georgiev I see the problem. If you take a look at PieChartComponent starting at line 87, you will see that when deselecting Show Labels, margins still contains [30, 80, 30, 80]. The update needs to reset the margins to the intended default of [20, 20, 20, 20].

This brings up another question though. Why are the margins being set at all? I would think that when I want to fit to the container, there should be no margins. Do you agree?

Also, since the margin is hard-coded to 20 pixels all around and the calculations for the height and width are made using the margins, you will see the effective margins get bigger as the size gets smaller. This is another reason why I think the margins should be removed. Instead, the spacing inside a container should be handled by CSS.

[marjan-georgiev]

Hi all, just merged the PR, will be in the next release. Would need to add the margins input to all charts before we release, so they are all consistent. If anyone is interested in working on that, please let me know.

Thanks!