Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Sorting should be handled on server side

See original GitHub issue

I’m submitting a …

[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here

Current behavior When using external paging, when clicking column header pagination is triggered on client side.

Expected behavior When external paging is active, sorting operations should be executed on server side

Reproduction of the problem https://swimlane.gitbooks.io/angular2-data-table/content/examples/server-paging.html Change page => company.json is called Change sort => no server calls

What is the motivation / use case for changing the behavior? Having accurate displayed data

Issue Analytics

State:
Created 7 years ago
Comments:8 (7 by maintainers)

Top GitHub Comments

1reaction

amcdnlcommented, Nov 11, 2016

Ya, I was kinda torn on this.

So in 1.0 I made it where if you pass a falsey, it will not use the compare fn. This allows u to use client side for some columns and server sorting for others at the same time. In hind sight, I’m not sure how useful that actually is but seemed like good idea at time. My goal was to try to make as minimal and implicit api as possible.

I do agree it can be confusing and since we already have external paging flag ill fold and add this too.

0reactions

amcdnlcommented, Dec 4, 2016

Fixed in latest. Use externalSorting prop.