SummaryRow applies even when there is no SummaryFunc

I’m submitting a … (check one with “x”)

[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, post on Stackoverflow or Gitter

Current behavior

<ngx-datatable
    class="bootstrap"
    [summaryRow]="enableSummary"
    [summaryPosition]="summaryPosition"
    [columnMode]="'force'"
    [headerHeight]="40"
    [rowHeight]="'auto'"
    [rows]="rows">
    <ngx-datatable-column prop="name" name="Nome"></ngx-datatable-column>
    <ngx-datatable-column 
		prop="valorDocumento" 
		[summaryFunc]="summValorDocumento">
	</ngx-datatable-column>
</ngx-datatable>

Results in a footer summary row with: [ name1name2name3 | 1000 ]

Expected behavior Since I am not giving a summaryFunc for the first column prop=“name”, I expected a footer summary row like this: [ empty here | 1000 ]

Reproduction of the problem

Please tell us about your environment: OS: Windows 10 IDE: Visual Studio Code package manager: Yarn and NPM

• Table version: 11.3.0 and 12.0.0

• Angular version: 6.0.0 and 4.1.0

• Browser: Chrome

• Language: [all | TypeScript X.X | ES6/7 | ES5] TypeScript 2.4.2 and 2.7.2

[SirWojtek]

Hello @cassianomon, thank you for creating the issue. I’ll try to look at your problem deeply in this week, I need to gather all possible solutions. As a workaround, I suggest you to “trick” template passing an empty function:

HTML

<ngx-datatable-column prop="name" name="Nome" [summaryFunc]="noop"></ngx-datatable-column>

TS

noop() { return null; } 
// or
noop() {}

[SirWojtek]

@cassianomon After I perform a couple of example usages of a summary row I must admit putting null on every non-number row can be a frustrating experience so I’ve decided to remove the throw statement from the default summary function.

PR containing the fix for this issue is ready to be reviewed. If you like to test it, you can download my branch and build it on your own.