Unable to add a row if sorting is set

I’m submitting a … (check one with “x”) bug report

Current behavior Add doesn’t work if sorting is enabled

Expected behavior Add works fine even if sorting is enabled

Reproduction of the problem

1. Open Basic/Live Data page demo in a browser
2. Set sorting on any column
3. Click Add button at the top

What is the motivation / use case for changing the behavior? Adding rows while sorting is set? 😃

Please tell us about your environment: Windows 8.1 x64 Node 7.7.3

• Table version: 0.8.x The latest from the repo

• Angular version: 2.0.x The latest from the repo

• Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ] Chrome 58.0.3029.81

• Language: [all | TypeScript X.X | ES6/7 | ES5] all

[akkaradej]

sortRows() returns the copy of rows. https://github.com/swimlane/ngx-datatable/blob/9.2.0/src/utils/sort.ts#L67

If we enable client-side sorting, this copy will be assigned to ngx-datatable’s rows. https://github.com/swimlane/ngx-datatable/blob/9.2.0/src/components/datatable.component.ts#L107

So, our rows array has different reference from ngx-datatable’s rows at the beginning.

My work around is re-assigning rows after modified.

this.rows.push({});
this.rows = [...this.rows];

[JosephAntoniou]

This is the case also with remove.