Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Should `/apis/generator/save` API be available by default

See original GitHub issue

This is a…


[ ] Feature request
[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Documentation issue or request

Description

We expose /apis/generator/save API by default, the API documentation states that it’s a test method, should we have it exposed by default?

https://github.com/syndesisio/syndesis/blob/6c84953b817675783d5613324dd610fc04670f06/app/server/endpoint/src/main/java/io/syndesis/server/endpoint/v1/handler/api/ApiHandler.java#L94-L112

Options are that it’s available behind a feature flag endpoints.test_support.enabled and/or moved to TestSupportHandler.

I’m guessing this was something requested by the @syndesisio/qe?

Issue Analytics

State:
Created 5 years ago
Comments:6 (5 by maintainers)

Top GitHub Comments

1reaction

nicolaferrarocommented, Sep 26, 2018

The /generator/save API was necessary to be able to develop the different parts of the API provider story without the need to have the UI upload feature first.

Now the UI upload part is being developed by @riccardo-forina. After it is merged (and I think it will use the /generator - without /save - path), the save endpoint can be completely removed, as not needed anymore.

0reactions

tplevkocommented, Oct 5, 2018

Verified by QE, closing