[Upgrade] Upgrade clears the syndesis-pull-secret link from service accounts

This is a…

[ ] Feature request
[ ] Regression (a behavior that used to work and stopped working in a new release)
[X] Bug report  
[ ] Documentation issue or request

Description

I created the syndesis-pull-secret secret with my authentication details and deploy 7.3.1. Now when I do the upgrade, what the upgrade pod does is:

...
=== * Update resources (upgrade_40_update_resources)
      - ServiceAccount: force update (delete/create)
        * syndesis-default
        * syndesis-integration
        * syndesis-prometheus
        * syndesis-server
...

so it deletes the old SAs with linked secret and replaces them with the ones from the template and those do not have the pull secret linked.

We will need to have this script https://github.com/syndesisio/syndesis/blob/1.6.x/tools/upgrade/migration/resource/any/03_ensure_service_account_setup.sh but not as a migration script (those are called before the SAs are re-created) but as part of the upgrade_40_update_resources script, after apply_resources call: https://github.com/syndesisio/syndesis/blob/d0c9225266b7dda3f4c1df326ed0583f39618f5a/tools/upgrade/steps/upgrade_40_update_resources#L48-L56

[nicolaferraro]

@avano if you already have a fix, please open the PR. I think the 1.6 migration script should be slightly changed to work on upstream (where we don’t have the pull secret), but it should be ok for 1.7.

[heiko-braun]

Fixed with https://github.com/syndesisio/syndesis/pull/6233