question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Unexpected changes in continuation behavior between 0.8.0 and 1.0.0 release?

See original GitHub issue

Initial checklist

Affected packages and versions

mdast-util-from-markdown@1.0.0 (via remark-parse@10.0.0)

Link to runnable example

https://codesandbox.io/s/rough-silence-cu56j?file=/src/grid/syntax.js

Steps to reproduce

In the linked codesandbox above, compare the rendered output (and console log) between remark-parse is locked at v9.0.0 vs v10.0.0

  • in v9.0.0 (mdast-util-from-markdown@^0.8.0): continuation correctly trigger exit when nok was returned, as seen in the console.log output of:

    #### START 
    onGridStart 
    shouldContinue?  ok 
    shouldContinue?  ok 
    shouldContinue?  nok 
    onGridExit 
    onGridStart 
    shouldContinue?  ok 
    shouldContinue?  ok 
    shouldContinue?  nok 
    onGridExit 
    
  • in v10.0.0 (mdast-util-from-markdown@^1.0.0): a 2nd “onGridStart” somehow gets triggered before the first continuation exits, leading to imbalance enter-exit effects pair:

    onGridStart 
    shouldContinue?  ok 
    shouldContinue?  nok 
    onGridStart 
    onGridExit 
    onGridStart 
    shouldContinue?  ok 
    shouldContinue?  nok 
    onGridExit
    

Expected behavior

a 2nd enter should not be triggered before the 1st exited

Actual behavior

a 2nd enter is triggered triggered before the 1st exited

Runtime

No response

Package manager

No response

OS

No response

Build and bundle tools

No response

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:7 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
ignatiusrezacommented, Aug 11, 2021

i see, i didn’t know that lazy line is a thing in markdown… i tested that the same change in behavior is observable in other construct as well, e.g. list…

given that the updated behavior is considered a bugfix, i’ll close this ticket…

0reactions
github-actions[bot]commented, Aug 11, 2021

Hi team! Could you describe why this has been marked as wontfix?

Thanks, — bb

Read more comments on GitHub >

github_iconTop Results From Across the Web

arrow/message.go at master · apache/arrow - GitHub
// Release decreases the reference count by 1. // Release may be called simultaneously from multiple goroutines. // When the reference count goes...
Read more >
Changelog and Migration Guide | Detekt
You can find the changes for each version using the dropdown menu on the top bar. Documentation for the upcoming version (next) can...
Read more >
Changelog — PyTorch Lightning 1.8.6 documentation
Changelog. All notable changes to this project will be documented in this file. The format is based on Keep a Changelog.
Read more >
Releases — Hangfire
This patch version fixes possible “stuck batch” issue when state of a job inside a batch continuation is changed externally before that batch...
Read more >
Databricks Runtime 7.0 (Unsupported) - Azure - Microsoft Learn
These changes are listed in the “Behavior changes” section of each functional area in the Apache Spark section of this release notes article:....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found