style-guide: ColorPalette doesn't show color labels
See original GitHub issueDescribe the bug The ColorPalette component from the style-guide package is not showing labels for my colors like in the style-guide docs
To Reproduce Steps to reproduce the behavior:
- Create a react project
- Add theme-ui and create a theme
- Make a page that uses the
ColorPalette
component - See the colors, but no labels below them. On hover, see the label
undefined
Note: This might not be all the steps required to reproduce the issue. I will attempt to create a minimal reproduction of the issue and update the issue later.
Expected behavior I would expect to see the name of the colors (the key in the theme file) below the colored squares, as seen in the style-guide docs.
Screenshots
As we can see in the screenshots, there is space below the swatches where the label should be. I believe the label ends up being undefined
for some reaason or other.
Additional context See the theme page where the issue is seen. See also the github repository with the source code.
Here’s the source code where the color palette is declared:
<Card>
<Heading>Colors</Heading>
<ColorPalette
omit={[
'modes',
'placeholder',
'twitter',
'instagram',
'facebook',
]}
/>
</Card>
I’ve tried playing around with the colors
object in the theme file with no effect, so I don’t think it is relevant to the issue.
Are the docs using an unreleased version of the package, perhaps?
Issue Analytics
- State:
- Created 2 years ago
- Comments:15 (15 by maintainers)
Top GitHub Comments
@braaar TBH I’m not sure if it would build at all if you mean the deep import
../../color
. I see no reason not to import{ getColor } from '@theme-ui/color'
though.I have still not managed to pinpoint why this goes wrong, but I have found a fix that works. If I use
getColor
from@theme-ui/color
instead ofget
fromtheme-ui
to get the colors inside theColorSwatch
component, the titles are defined correctly.I made these changes in the javascript
dist
files in thebjerkio/brand
project:node_modules/@theme-ui/style-guide/dist/theme-ui-style-guide.cjs.dev.js
(and a couple of other similarly named files)Here is what the changes would look like if added to the
style-guide
tsx source code:packages/style-guide/src/ColorSwatch.tsx
line 20, replacewith:
(and add
import { getColor } from '../../color/src'
)I’m not sure of the implications of adding this dependency. Is this problematic?
Anyway, I hope this info could be useful in finding the bug, at least.