question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Self-claiming of ComiCake extension

See original GitHub issue

Hi, just wanted to let people who write extensions know that I’m already working on an extension for my new reader (in development). The reader has been implemented over at whimsubs.xyz and will be replacing foolslide2 in a weeks over at jaiminisbox.com.

I do have a question though regarding dev: When getting latestUpdates from a source, tachiyomi wants a MangasPage, which is basically a container for a list of SManga. Problem with this though is that when fetching latest chapters from the api at /api/chapters.json, because they’re chapters, just chapter data is returned:

{
    "id": 64,
    "manifest": "/r/read/5b51fe81-470d-436d-b6d3-5551d8a6d98e/manifest.json",
    "comic": 12,
    "name": "A Summoner's Sage Skills",
    "chapter": 15,
    "subchapter": 0,
    "title": "Chapter 15: A Summoner's Sage Skills",
    "protection": null,
    "uniqid": "5b51fe81-470d-436d-b6d3-5551d8a6d98e",
    "volume": 0,
    "team": [1],
    "language": "en",
    "published_at": "2018-05-27T10:14:28-07:00",
    "modified_at": "2018-05-27T12:11:53.280321-07:00"
}

The manga is only referenced by an ID, so for each manga with a new chapter you would have to fetch that manga’s details at /api/comics/${id}.json, which would result in quite a few API requests. The next-best option I see is to just prefetch all comic metadata as well from /api/comics.json?page=${page}, but I’m not sure. Suggestions?

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:24 (17 by maintainers)

github_iconTop GitHub Comments

1reaction
chocolatkeycommented, Jun 11, 2018

@CarlosEsco solved problem, have an option to expand the comic field to produce chapter output like this:

{
    "id": 11,
    "manifest": "/r/read/f231ed70-62ec-46ed-b4d1-0e11f4d9446d/manifest.json",
    "comic": {
        "id": 1,
        "name": "Koi ni Hizu",
        "uniqid": "211691c2-e764-4534-ad58-fe9aef2121f1",
        "slug": "koi-ni-hizu",
        "alt": "恋ニ非ズ",
        "cover": "http://localhost:8000/static/media/211691c2-e764-4534-ad58-fe9aef2121f1/13932016480029269956-8b52ad82fac28f568f40cf7ea5c50c5a.png"
    },
    "name": "不義",
    "chapter": 4,
    "subchapter": 0,
    "title": "Chapter 4: 不義",
    "protection": null,
    "uniqid": "f231ed70-62ec-46ed-b4d1-0e11f4d9446d",
    "volume": 0,
    "team": [
        1
    ],
    "language": "ja",
    "published_at": "2018-05-21T00:35:00-07:00",
    "modified_at": "2018-06-05T23:55:02.420780-07:00"
},

and it works 😃

0reactions
arkoncommented, Sep 8, 2019

Not sure if this is still relevant since the extension already exists.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Self-claiming of ComiCake extension · Issue #354 - GitHub
Hi, just wanted to let people who write extensions know that I'm already working on an extension for my new reader (in development)....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found