useQuery return always isLoading with true when enabled is false

Describe the bug

When I created useQuery with enabled: false option, isLoading variable is always true.

Your minimal, reproducible example

https://codesandbox.io/s/react-query-enabled-7u58d5-7u58d5

Steps to reproduce

1. Create simple query by use useQuery,
2. Add enabled: false into options,
3. Check state for isLoading.

Expected behavior

State isLoading is false.

How often does this bug happen?

Every time

Screenshots or Videos

Platform

• OS: Windows 11 22H2,
• Browser: Chrome
• Version: 103

react-query version

4.0.10

TypeScript version

4.7.4

Additional context

No response

[TkDodo]

So I think I have up my mind for what I want to do for the next major version. Believe me, I am terribly sorry that I didn’t do this with v4 already. No one regrets this more than me. The plan is to:

1. rename status: 'loading' to status: 'pending'
2. rename isLoading to isPending (a simple derived state from the status, like isSuccess and isError)
3. re-introduce isLoading as derived value from: isPending && isFetching

That would allow our main status field to remain intact and describe data (pending/success/error), while also having a good isLoading boolean that works like in v3. The breaking thing would be that status === 'loading' wouldn’t exist anymore, as you would have to change it to status === 'pending'.

---

The thing is, if we introduce something now that combines the two like isInitialDataLoading or whatever, it wouldn’t actually be needed, as it would be isLoading as described above.

With that in mind, yes, I think we can:

• introduce a new field that combines isLoading && isFetching now.
• do the proposed changes in v5
• deprecate the new field that we introduce now in v5 and “alias” it to the then good isLoading
• remove it in v6.

Please drop more name suggestions, and I’ll also run this proposal by @tannerlinsley

[anglee]

I found this issue after running into the same issue and spending time debugging it. And tbh, I also had the same ‘are you serious?’ thought.

For a breaking change like this, I didn’t find the word ‘enabled’ used in the doc Migrating to React Query 4. It would be helpful to include explicit instructions (e.g. a before&after code example) about how to migrate code with enabled: false in the guide.