Inconsistent parameters received on toggleSelection handler of selectTable HOC

Right now, if you use the default input component, the toggleSelection handler gets called with these parameters:

onClick={(e)=>{
  const { shiftKey } = e;
  e.stopPropagation();
  props.onClick(props.id, shiftKey, props.row);
}}

If you use a custom SelectInputComponent, the toggleSelection receives the SyntheticEvent object from React. So it makes it impossible to know, for example, which row was clicked.

I think both methods should receive the same arguments.

[nlucero]

Yeah, that works 👍

Just as an opinion, it would be nice if the user wouldn’t need to know how the HOC internally works in order to implement a custom Select Input component. Regardless of the Select Input component used on the table, the toggleSelection handler should receive the same parameters.

I will close this issue. Thanks for your help!

[gary-menzel]

you get the data you are asking for in the props.

Add this line to your render just before you return and you will see the props there…

    console.log('props',this.props);

You have to replicate the functionality of the default component otherwise it won’t work. Here is the source code pasted (it is in the code)…

const defaultSelectInputComponent = (props) => {
  return (
    <input 
      type={props.selectType || 'checkbox'} 
      checked={props.checked} 
      onClick={(e)=>{
        const { shiftKey } = e;
        e.stopPropagation();
        props.onClick(props.id, shiftKey, props.row);
      }} 
      onChange={()=>{}}  
    />
  )
}