Cannot get correct scroll on last item

Hi! I picked up Kent’s work on useCombobox and react-virtual and came up with this: https://codesandbox.io/s/epic-morse-jffe1.

Released an alpha for Downshift to fix some things, and now it should work, apart from this use case: highlighting from first item to last (using ArrowUp) is not bringing the item into view. Scroll somehow fails (unless I pass {align: 'start'} to the scroll function. However I don’t want to do that for all cases.

Last item is scrolled correctly when moving from second to last to last (using ArrowDown).

Any idea why I get this bad scroll in the use case above? Thanks!

[silviuaavram]

I think the problem is right inside the method calculating the next highlighted index, I also need to check if items.length is 0. Will fix and write a test in the PR already opened.

nit: you can use onHighlightedIndexChange @kentcdodds so you don’t have to perform that check inside the onStateChange.

[tannerlinsley]

Just pushed a fix for this. And better yet, it fixes some other edge cases with dynamic virtualization as well. Update your sandbox dep and you should be good to go 😃