Make users aware of risks when implementing autoComplete
See original GitHub issueHello guys, thank you for your contribution, however I suggest you make the users aware that they have to work on protecting their search form from XFS & XSS attacks… e.g.
Goto your own example form https://tarekraafat.github.io/autoComplete.js/demo/ and search literally for:
<a href="javascript:alert('Hi')">hi</a>
then search literally for:
<iframe src="https://tarekraafat.github.io/autoComplete.js/#/" height="200" width="300" title="Iframe Example"></iframe>
Malicious users may find autoComplete a source of vulnerable clients or victims for attacking others or right on them.
My suggestion is to make users aware of such risks before they go into production. To check their code for Cross-Frame Scripting and Cross-Site Scripting vulnerabilities…
I am not saying you are super wrong, no, your contribution is beautiful, yet there are less experienced users out there probably implementing your code.
Cheers.
Issue Analytics
- State:
- Created 2 years ago
- Comments:7 (3 by maintainers)

Top Related StackOverflow Question
Hello @needlag,
I totally agree with you on your point of spreading awareness of the possible risks.
That’s why I have added to the library’s docs under the
Usagesection a security alert on this specific risk along with some recommendations, and please feel free to check it out and share your feedback on it if you’d like to.Thank you for raising such a critical point, and have a nice day! 😃
@folknor, good catch as usual!
I’ve fixed it and publishing it now, and I’ve added
escape-goatto the references as well.Thanks man, and have a nice day! 😃