Returning an error from data.src triggers exception

In the official codepen playground and other places you have this code now:

src: async () => {
      try {
        return data;
      } catch (error) {
        return error;
      }
}

But if this errors, autoComplete.js triggers an exception:

19:08:26.990 Uncaught (in promise) TypeError: data.store.forEach is not a function
    findMatches dataController.js:36
    default index.f58c4ea9.js:22807
    run eventController.js:27
    timer io.js:89
    setTimeout handler*debounce/< io.js:89
    input eventController.js:41
    addEvents eventController.js:71
    eventsManager eventController.js:14
    addEvents eventController.js:70
    default index.f58c4ea9.js:22471
    autoComplete autoComplete.js:37
    init index.f58c4ea9.js:1261

Because in start.js or findMatches you never validate that it didn’t error.

Also on a sidenote, I don’t think cache is working at the moment (though I believe the cache should be removed anyway), because you never set data.cache anywhere:

$ pwd
/home/folk/.../node_modules/@tarekraafat/autocomplete.js/src
$ rg '.cache'
services/init.js
48:  if (data.cache) await getData(ctx);

controllers/dataController.js
12:  if (data.cache && data.store) return;

[folknor]

Also https://github.com/TarekRaafat/autoComplete.js/blob/7e1930626ae8cc9a8ac90fd3aac4fdf31202866b/src/autoComplete.js#L38 is wrong. I had not tried it when I wrote that, it should say something like “Makes the Tab key select the entry navigated to using the keyboard, just like Enter.”

config.data.filter should perhaps say “Used to filter and sort matching returns from config.data.src before showing them to the user. Signature: (Array), is given all the results from config.data.src that matches the query.”

[folknor]

I think I misunderstand your last comment. I’m not really able to parse and understand what you said 😛

Anyway it could be as simple as changing start.js from

    // Check if data fetch failed
    if (ctx.feedback instanceof Error) return;
    // Find matching results to the query
    findMatches(queryVal, ctx);
    // Render "resultsList"
    if (resultsList) render(ctx);

to

    if (ctx.feedback instanceof Error) {
      if (resultsList && resultsList.element && resultsList.showError) {
        ctx.cursor = -1;
        ctx.list.innerHTML = "";
        resultsList.element(ctx.list, feedback);
        open(ctx);
      }
    } else {
      // Find matching results to the query
      findMatches(queryVal, ctx);
      // Render "resultsList"
      if (resultsList) render(ctx);
    }

I realise it looks dirty. Also I’ve not tested it, and start.js needs to import open from listController. And if I was going to implement it “properly” I’d move this logic to listController, probably adding a reset function there for resetting .cursor and .innerHTML and so forth.

Anyway again I don’t really understand your previous comment so if this comment is useless please excuse me. I do understand that the error is in feedback and data.store, but not the sentence before that - this one:

Frankly, that’s how I was planning to handle errors because if it’s going to be limited to the list, then in case you’re not using the default rendered list for some reason you won’t be able to catch them and use them.