Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Perfomance is very slow when a HTML comment is inside a JavaScript block

See original GitHub issue

I’ve mistakenly placed a HTML comment inside a JavaScript block that caused the time to load a page to increase from 200-300 ms to 6-7 seconds. Besides this, that block contained a quiet large JSON array, but removing that comment did the perf fix.

Obviously the comment shouldn’t have been there, but I still think it is an issue if this causes such a drop in the load time.

Issue Analytics

State:
Created 7 years ago
Comments:5 (3 by maintainers)

Top GitHub Comments

1reaction

Taritsyncommented, Mar 5, 2017

Are these statistics enabled by default?

By default, generation of statistics is disabled, because it slightly reduces performance.

Is there anything else to do besides writing an ILogger implementation to log the statistics?

Unfortunately, now in ASP.NET extensions is missing the ability to enable generation of statistics (logger always gets its equal to null), but in next release I will add this feature.

0reactions

adrianiftodecommented, Mar 8, 2017

Many thanks!

2017-03-08 18:05 GMT+02:00 Andrey Taritsyn notifications@github.com:

Hello, Adrian!

Unfortunately, now in ASP.NET extensions is missing the ability to enable generation of statistics (logger always gets its equal to null), but in next release I will add this feature.

I have added this feature in version 2.3.0 https://github.com/Taritsyn/WebMarkupMin/releases/tag/v2.3.0. In markup minification managers and options was added a new property - GenerateStatistics (default false).

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/Taritsyn/WebMarkupMin/issues/31#issuecomment-285083630, or mute the thread https://github.com/notifications/unsubscribe-auth/ANHaa-Us152EkduQtVRu89r_Sws5GEmAks5rjtHVgaJpZM4MRkYS .