[Windows] Compilation warnings: unknown option '-std=c++11'

Hello, first of all, great work on this tool! it works like a charm!

I’m a windows user, and the default example raises 2 warnings because of those flags I believe: https://github.com/tbenthompson/cppimport/blob/9b3326424c90e7023e34a1ca413221f6509049a3/cppimport/templating.py#L30

cl : Command line warning D9002 : ignoring unknown option '-std=c++11'
cl : Command line warning D9002 : ignoring unknown option '-fvisibility=hidden'

I think msvc has its own set of compiler flags (like /std:c++11) and using those on windows might fix those warnings. Thanks again for the good work!

[tbenthompson]

Huh, are you sure you’re linking in the JUCE library at all? You may need to add something like

cfg['include_dirs'] = ...
cfg['libraries'] = ['juce'] 

Or whatever the appropriate library name would be. Generally, C++ libraries have headers that needed to included at compile-time and libraries that need to be linked at link-time. In general, I’d suggest you start by getting a simple single C++ file compiling with the library before adding complexity like Python bindings. That’ll also help you understand the various compiler and linker flags and get a better scaffolding for debugging these kinds of problems in the future.

I’m going to close this since I’m pretty sure cppimport isn’t causing your issues. Hope you resolve your problem!

[kokounet]

Hello again!

Thank you again for your comment, I managed to make it work after all! It was indeed not cppimport causing the issue. I needed to add information on how to compile the library and link to a bunch of system libraries as well!

now the config looks something like this:

<%
import glob
import sys
cfg["include_dirs"] = [
    "JuceLibraryCode",
    "JuceLibraryCode/modules",
    "JuceLibraryCode/modules/juce_audio_processors/format_types/VST3_SDK"
]
cfg["sources"] = sorted(glob.glob("JuceLibraryCode/*.cpp"))
if sys.platform == "win32":
    cfg["libraries"] = [
        "kernel32", "user32", "gdi32", "winspool", "comdlg32", "advapi32",
        "shell32", "ole32", "oleaut32", "uuid", "odbc32", "odbccp32",
    ]
elif sys.platform == "darwin":
    cfg["libraries"] = []
setup_pybind11(cfg)
%>