clarify connection pooling

Regarding connection pooling… if I request a new sql.Connection(cfg) (more than once) will it return a connection from the same pool (based on cfg options), or will it create a new pool?

Regarding v2 (Promises based) if the above isn’t the behavior, could it be made to be the behavior internally? I’m doing something similar to the following, but if I could just have the same connection from a pool, that would be awesome.

https://gist.github.com/tracker1/5ad0bff295369ac05eea

[tracker1]

@mbrio - mssql’s connection is always a pool…

I usually do something like…

//getConnection module
var conOptions = require('../config/sql'); //store your connection options wherever
var mssql = require('mssql');
var Promise = require('i-promise'); //use whatever promise library you like
var cp = null;
module.exports = getConnection;

function getConnection(){
  if (cp) return cp;
  return cp = new Promise(function(resolve,reject){
    var conn = new mssql.Connection(conOptions, function(err){
      if (err){
        cp = null;
        return reject(err);
      }
      return resolve(conn);
    });
  });
}

Then from the outside…

var cp = require('../sql/get-connection');
...
  cp.then(
    function(conn){
      //do something with connection
      var request = new mssql.Request(conn);
    },
    function(err){
      console.error(err);
      process.exit(666);
    }
  )
...

there’s also… connection.connect() but I’m not sure if it will resolve the actual connection… in my case, the same promise/connection will always be returned, and it is indeed a pool.

[benjaminmbrown]

This is one of my favorite GH issues I’ve come across - good questions on a tricky subject and great answers with usable examples. Helped me out a ton! Thx guys