Mssql cause node.js instance exit after a few queries

Hi,

First, thank you for the job you have done with this it looks great !

But I am having a little issue querying database a few times in a row :

Here is the code

try {

var timeOutCallback = function() {
    var config = {
        "user": "msq2RTFlow",
        "password": "msqService4RTFlow",
        "server": "localhost",
        "database": "MSQ"
    };
    var connection = new mssql.Connection(config);
    connection.connect().then(function() {
        var request = new mssql.Request(connection);
        request.query('SELECT * FROM Patient;').then(function(recordset) {
            console.log(recordset.length);
            connection.close();
            timeoutId = setTimeout(timeOutCallback, 1000);
        }).catch(function(err) {
            console.log(err);
            connection.close();
            timeoutId = setTimeout(timeOutCallback, 1000);
        });
    }).catch(function(err) {
        console.log(err);
        connection.close();
        timeoutId = setTimeout(timeOutCallback, 1000);
    });
};
var timeoutId = setTimeout(timeOutCallback, 1000);

} catch (p_error) {
    console.log(p_error);
}

I took the code to query databasase directly from exemples using promises. Even if I’m not using promises, I am experiencing the same issue. I Am not having neither of my error logs in console, I’m having 7 results from query, ten times, then it stops with no message or error at all.

[tracker1]

The following pattern will give you an existing connection/pool when available, as well as support closing, which will kill the handle to the pool, and connection.

IMHO, this should really be the default behavior… why the connection callback doesn’t return the connection is beyond me… also, that there isn’t an internal pool-list is a bit odd too, imho. I’m doing something similar for mssql-ng, which wraps this library with a template processor for parameterized queries.

//getConnection Module
var pool = null;
module.exports = function getConnection() {
  var config = {
    user: "msq2RTFlow",
    password: "msqService4RTFlow",
    server: "localhost",
    database: "MSQ"
  };

  if (pool) return pool;
  var conn = new mssql.Connection(config);

  //override close behavior to eliminate the pool
  var close_conn = conn.close;
  conn.close = function(){
    pool = null;
    close_conn.apply(conn, arguments);
  }

  return pool = conn.connect()
      .then(function(){ return conn; })
      .catch(function(err){
        pool = null;
        return Promise.reject(err);
      });
}

[willmorgan]

Pooling and individual connection lifecycle management has been improved in recent releases so I’m closing this in the hope that upgrading to the latest version resolves the matter.