mssql uri connection string: enableArithAbort

I updated to the most recent node-mssql version and now I am getting a tedious deprecated warning: tedious deprecated The default value for config.options.enableArithAbort will change from false to true in the next major version of tedious. Set the value to true or false explicitly to silence this message.

I have looked through this repository, but I only found the solution for passing a config to the ConnectionPool.

How would this work with the uri connection string? mssql://username:password@ip:1433/database?encrypt=true&enableArithAbort=false

Expected behaviour:

The deprecated message goes away

Actual behaviour:

Message is still there, eventhough the enableArithAbort is passed mssql://username:password@ip:1433/database?encrypt=true&enableArithAbort=false

Configuration:

mssql://username:password@ip:1433/database?encrypt=true&enableArithAbort=false

Software versions

• NodeJS: 10.5.0
• node-mssql: 6.1.0
• SQL Server: 13.0.4001.0

[dhensby]

I have now authored a better (and more generic) connection string parser

This has been integrated to the latest mssql v7 beta. At the moment the enableArithAbort option is still not supported and this is mostly because I’m not sure it’s right to add support for unlimited non-standard connection string properties just so we can then add them to the tedious object. However, I do concede I had added support from some non-standard options (like stream=true).

I think there are probably two options here:

1. We encourage people to parse their own connection string using the library and then provide the config object with the extra params they want to support - this helps keep the library less tightly coupled to version of tedious
2. We support more non-standard params in the query string.

[nfantone]

Yeah, I hear you. Mentioned it was “a workaround”. Although, that particular module has been around for more than four years - and it’s always going to be there for the current version. If it changes later on, it should be “as easy” as swapping the internal implementation for the external connection URI parsing tool.