Authentication type parameter seems to accept too many values

I noticed the allowed values for the authentication type parameter are being filtered down during runtime, but the type itself seems to accept string values, and even undefined.

I’m wondering whether the type of the authentication.type parameter can instead be set to something like

type AuthenticationType = 'default' | 'ntlm' | 'azure-active-directory-password' | 'azure-active-directory-access-token' | 'azure-active-directory-msi-vm' | 'azure-active-directory-msi-app-service' | 'azure-active-directory-service-principal-secret'
// ...
type: AuthenticationType;

This way, users would know exactly which values are valid for a given version of tedious.

[MichaelSun90]

I do not think you have to use that since we do support our own types within tedious. You can give it a try, see if it meet your needs. Our project is here. Also, you can try to post this issue on their board, see if they can help you on this. Hi @arthurschreiber, I am not sure why there is a DT mark on the npm page for tedious, have we used their type definition before we fully migrate to typescript?

[MichaelSun90]

Hi @Fuco1, Thank you for bring this up. We are using babel to compile the typescript, and seems it does not handles the type declarations. For generate the declarations , tsc is needed. Hi @arthurschreiber , did we not generate it for a purpose or is just because of using babel. For type declarations, should we want to set something for tsc to generate it?