Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

icon size

See original GitHub issue

Hi, why the icon size is multiplied by 1.5 ?

I refer to this snippet:

  const width = typeof size === "string" ? size : `${size * 1.5}rem`;

I am wrapping @mdi/react icon to add isSmall, isLarge props: I expected that size would be passed as is.

Issue Analytics

State:
Created 5 years ago
Comments:8 (6 by maintainers)

Top GitHub Comments

1reaction

fibocommented, Aug 31, 2018

@Templarian thanks, I am going to check it out. I will probably using your package in production at my new job, just in few minutes I am going to discuss about some proposal and among many others there will be this package.

Ahah I was like cause it was what I was looking for and it was just created, I putted like the fifth star on GitHub.

Thanks for sharing your software and for your passion, I hope you can find useful some packages I shared or at least I will try to contribute with feedbacks and maybe PRs.

Have a nice day, Gianluca.

1reaction

Templariancommented, Aug 23, 2018

Since you’re passing a string it will continue to work the same after the changes go out for v1.0.0. Your feedback along with 2 others convinced me we should change the default functionality in the final release, so thanks!