Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Context menu not being removed

See original GitHub issue

The last commit seems to have introduced a bug where the context menu isn’t removed when the user clicks outside it. I fixed this by changing the following line in removeAllContextMenus: Changed if ( !$(event.currentTarget).hasClass('context') ) { to if ( $(event.currentTarget).hasClass('context') ) {

Issue Analytics

State:
Created 7 years ago
Comments:5

Top GitHub Comments

1reaction

josetairacommented, Jan 16, 2017

click-out-issue

This is what I’m encountering. Seems like I can only replicate it when clicking outside the bounds of the html (the part that gets highlighted in blue). Is this the same thing for you? Particularly, when you click within the bounds of the <html></html> does it work?

0reactions

gconeycommented, Jan 16, 2017

The problem I saw was that clicking anywhere outside the context menu didn’t hide the context menu. I am using the latest ver of Chrome. The small change I suggested has fixed the issue completely.

Regards, George

From: Jose Taira [mailto:notifications@github.com] Sent: 16 January 2017 09:46 To: Templarian/ui.bootstrap.contextMenu ui.bootstrap.contextMenu@noreply.github.com Cc: George Coney gconey@cybertron.co.uk; Mention mention@noreply.github.com Subject: Re: [Templarian/ui.bootstrap.contextMenu] Context menu not being removed (#98)

[click-out-issue]https://cloud.githubusercontent.com/assets/15209679/21977969/6b7c9bce-dbd0-11e6-84ec-6df564226e26.gif

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Templarian/ui.bootstrap.contextMenu/issues/98#issuecomment-272815435, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKNnHIfVT11cjMiAzOemuJQ8tL_epF3pks5rSzxIgaJpZM4LeyOA.