question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Making run_docker.sh faster.

See original GitHub issue

Describe the feature and the current behavior/state.

Using docker to make the life of contributors easier is a very good idea. But the current implementation has a drawback (that we can fix).

Currently running any command with run_docker.sh installs dependencies even if the docker image is already present locally. For example every time I call:

bash tools/run_docker.sh -c 'make unit-test'

It downloads and install tensorflow, wich takes several minutes. Same for bash tools/run_docker.sh -c 'make code-format' which installs clang format every time.

What I propose is to make a dockerfile for each of those commands and install the necessary dependencies in it. Therefore, running bash tools/run_docker.sh -c 'make code-format' would takes only a few seconds the second time and we would avoid wasting bandwidth.

Relevant information

  • Are you willing to contribute it (yes/no): maybe
  • Are you willing to maintain it going forward? (yes/no): maybe
  • Is there already an implementation in another framework? (if so, where): In keras-tuner

Who will benefit with this feature?

Contributors

Any other info.

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

2reactions
gabrieldemarmiessecommented, Feb 5, 2020

See #1022 and #1021 where there is no need to use the interactive mode to have fast formatting and sanity check.

0reactions
gabrieldemarmiessecommented, Feb 6, 2020

See also #1030

Read more comments on GitHub >

github_iconTop Results From Across the Web

Tips to run Docker Build faster | by Vicky AV | Dec, 2020
How to make Docker build command run faster ? Applicable to building docker image for Angular, NodeJS, Spring Boot Application etc.
Read more >
Six Ways to Build Docker Images Faster (Even in Seconds)
Docker makes it possible to package applications and run them in an isolated environment called a container. Thanks to such isolation, ...
Read more >
Slow Docker on Windows WSL2? Fast and easy fix to improve ...
Solution for Docker performance improvement · Step 1: ENABLE WSL2 on Windows · Step 2: install SSH on Ubuntu · Step 3: Configure...
Read more >
docker run - Docker Documentation
The docker run command first creates a writeable container layer over the specified image, and then starts it using the specified command. That...
Read more >
Docker: Easy as build, run, done! - freeCodeCamp
These are the files we will use with Docker. Dockerfile build.sh run.sh. Before we can use Docker, we must first install it. Below...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found