question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Requirement] Upgrade typescript to a higher version

See original GitHub issue

After upgrading webgpu/types from 0.1.16 to 0.1.21, I always meet below errors in PR https://github.com/tensorflow/tfjs/pull/6862:

Step #2 - "run-cloudbuild": Step #20 - "build-tfjs": �[96m../node_modules/@webgpu/types/dist/index.d.ts�[0m:�[93m587�[0m:�[93m16�[0m - �[91merror�[0m�[90m TS2304: �[0mCannot find name 'PredefinedColorSpace'.
Step #2 - "run-cloudbuild": Step #20 - "build-tfjs": 
Step #2 - "run-cloudbuild": Step #20 - "build-tfjs": �[7m587�[0m   colorSpace?: PredefinedColorSpace;
Step #2 - "run-cloudbuild": Step #20 - "build-tfjs": �[7m   �[0m �[91m               ~~~~~~~~~~~~~~~~~~~~�[0m
Step #2 - "run-cloudbuild": Step #20 - "build-tfjs": 
Step #2 - "run-cloudbuild": Step #20 - "build-tfjs": �[96m../node_modules/@webgpu/types/dist/index.d.ts�[0m:�[93m728�[0m:�[93m16�[0m - �[91merror�[0m�[90m TS2304: �[0mCannot find name 'PredefinedColorSpace'.
Step #2 - "run-cloudbuild": Step #20 - "build-tfjs": 
Step #2 - "run-cloudbuild": Step #20 - "build-tfjs": �[7m728�[0m   colorSpace?: PredefinedColorSpace;
Step #2 - "run-cloudbuild": Step #20 - "build-tfjs": �[7m   �[0m �[91m               ~~~~~~~~~~~~~~~~~~~~�[0m
Step #2 - "run-cloudbuild": Step #20 - "build-tfjs": 
Step #2 - "run-cloudbuild": Step #20 - "build-tfjs": �[96m../node_modules/@webgpu/types/dist/index.d.ts�[0m:�[93m800�[0m:�[93m16�[0m - �[91merror�[0m�[90m TS2304: �[0mCannot find name 'PredefinedColorSpace'.
Step #2 - "run-cloudbuild": Step #20 - "build-tfjs": 
Step #2 - "run-cloudbuild": Step #20 - "build-tfjs": �[7m800�[0m   colorSpace?: PredefinedColorSpace;
Step #2 - "run-cloudbuild": Step #20 - "build-tfjs": �[7m   �[0m �[91m               ~~~~~~~~~~~~~~~~~~~~�[0m
Step #2 - "run-cloudbuild": Step #20 - "build-tfjs": 
Step #2 - "run-cloudbuild": Step #20 - "build-tfjs": 
Step #2 - "run-cloudbuild": Step #20 - "build-tfjs": Found 3 errors.

It seems that upgrading typescript to 4.8.4 can fix this issue. But it also brings some other format errors.

Issue Analytics

  • State:closed
  • Created a year ago
  • Comments:5 (2 by maintainers)

github_iconTop GitHub Comments

1reaction
mattsoulanillecommented, Sep 29, 2022

Yes, @qjia7, we have wanted to upgrade TypeScript for a while now (#6346, #5561). However, we have been delaying it to the next major release since it seems to have breaking changes in a specific case. We would like to do a major release soon, though, which will include TS4 and some improvements to our npm package format.

The first step for this is to create a release RC branch and update and merge the TS upgrade PR into it. I’ll keep you updated on this process and let you know when the release branch with TS4 is ready.

0reactions
qjia7commented, Oct 13, 2022

The 4.0 dev branch which upgrades TypeScript to 4.8.4 and webgpu/types to 0.1.21 is now merged into master. We’re planning on only upgrading TypeScript in this 4.0 release because it’s time sensitive (due to this issue and some internal google3 issues). We’ll do another major release for the package format changes I mentioned above and any other breaking changes, and we’ll have a longer merge process for 5.0 so we can accept breaking changes from contributors.

Thank you very much for your great efforts on this!

Read more comments on GitHub >

github_iconTop Results From Across the Web

How to upgrade Typescript to the latest version?
You might be able to check the version of TypeScript by using this command: npm view typescript version on the command line. –...
Read more >
How to Upgrade to TypeScript Without Anybody Noticing, Part 1
This guide will show you how to fix Typescript compile errors in Javascript project that recently added Typescript support via a tsconfig.json.
Read more >
How to set up TypeScript
To do this, run npm install -g typescript . This will install the latest version (currently 4.9). An alternative is to use npx...
Read more >
Upgrading to React 18 with TypeScript - LogRocket Blog
It's important to note that npm is built on top of semantic versioning. To make consumption of type definitions easier, the versioning of...
Read more >
what's your process regarding breaking changes? : r/typescript
How to upgrade TypeScript versions - what's your process regarding breaking changes? · Switch to latest version, run a TS build and address ......
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found