Its unclear how to set symmetry correctly

I converted a 1/3 core reactor to full core using ThirdCoreHexToFullCoreChanger.convert

After expanding the symmtry is set using

r.core.symmetry = geometry.SymmetryType(
    geometry.DomainType.FULL_CORE, geometry.BoundaryType.NO_SYMMETRY
)

My code also tests weather its full core using

if self.r.core.isFullCore

which checks

return self.symmetry.domain == geometry.DomainType.FULL_CORE

Since core.symmetry was set, but self.symmetry.domain is checked for symmetry, it still believes it is not full core

Please advise why both core.symmetry and self.symmetry.domain exist, and how to communicate to ARMI that it is now full core.

[onufer]

Thanks for explanation, issues is probably on my end

[john-science]

@onufer I have ammended the unit test as follows, and it still passes:

    def test_growToFullCoreFromThirdCore(self):
        """Test that a hex core can be converted from a third core to a full core geometry.""" 
        # Check the initialization of the third core model  
        self.assertFalse(self.r.core.isFullCore)  
        self.assertEqual( 
            self.r.core.symmetry,   
            geometry.SymmetryType( 
                geometry.DomainType.THIRD_CORE, geometry.BoundaryType.PERIODIC 
            ), 
        ) 
        initialNumBlocks = len(self.r.core.getBlocks()) 
        # Perform reactor conversion 
        changer = geometryConverters.ThirdCoreHexToFullCoreChanger(self.o.cs) 
        changer.convert(self.r) 
        # Check the full core conversion is successful 
        self.assertTrue(self.r.core.isFullCore)    # NOTE: This is new.
        self.assertGreater(len(self.r.core.getBlocks()), initialNumBlocks)  
        self.assertEqual(self.r.core.symmetry.domain, geometry.DomainType.FULL_CORE) 
        # Check that the geometry can be restored to a third core  
        changer.restorePreviousGeometry(self.o.cs, self.r) 
        self.assertEqual(initialNumBlocks, len(self.r.core.getBlocks())) 
        self.assertEqual(  
            self.r.core.symmetry,  
            geometry.SymmetryType( 
                geometry.DomainType.THIRD_CORE, geometry.BoundaryType.PERIODIC 
            ),  
        ) 
        self.asserFalse(self.r.core.isFullCore)  # NOTE: This is new.

So the basic unit test checks out. Is this not what you expected? OR do you see something different with your data?