question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Need some checks on the class1/class2 material modifications

See original GitHub issue

For materials derived from the FuelMaterial class, a user can blend two materials together using the class1/class2 material modifications (see here). The applyInputParams method used to accomplish this could use some checks on the material modifications that are supplied by the user.

The following checks would be very useful:

  1. Make sure that class1_wt_frac is between 0 and 1 (inclusive), otherwise negative isotopic densities can occur.
  2. Make sure that class1_custom_isotopics and class2_custom_isotopics point to existing custom material definitions. This is very important because if the user points to a non-existing custom material, the code errors but catches an exception in the _constructMaterial call, so applyInputParams fails silently and the code continues as if nothing went wrong.

I’d be happy to implement the checks myself, if others agree that they are needed.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
kecklercommented, Jan 5, 2022

It seems like both checks could be put straight into the applyInputParams method of the FuelMaterial class. If that were the case, then the checks would run at the beginning of a case when the block blueprints are constructed. One set of checks for every FuelMaterial component in each block blueprint. So it’s not like the check would be called at every burn step, or even at every burn cycle. For a typical case that has only a handful of unique block blueprints, I don’t think it should be very onerous.

I will try to implement this and see how much overhead it requires. I have a rather big case with a lot of blueprints that I’ll test it out on.

0reactions
kecklercommented, Feb 8, 2022

Closed! Thanks for the reminder!

Read more comments on GitHub >

github_iconTop Results From Across the Web

How to Comply with Federal Hazardous Materials Regulations
This document provides only a general overview of the requirements for transporting hazardous materials by highway.
Read more >
Hazard Classification Guidance for Manufacturers, Importers ...
It contains recommendations as well as descriptions of mandatory safety and health standards. The recommendations are advisory in nature, informational in ...
Read more >
Class 1 vs 2 Stainless - Portland Bolt
Hi,. We have received a B8M Class 2 Bolt Shipment from our supplier. What is the proper way to have it tested? Our...
Read more >
Frequent Questions About Hazardous Waste Permitting
Modifications may be required to address such changes as alterations or additions at a facility, new information about the facility, and new regulatory ......
Read more >
49 CFR Part 173 -- Shippers - General Requirements ... - eCFR
(1) Each inner receptacle must be constructed of plastic, or of glass, porcelain, stoneware, earthenware or metal. When used for liquid hazardous materials, ......
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found