question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

No warning when material modification is unused

See original GitHub issue

Right now if you define an assembly with a material modification that is not recognized, ARMI does not tell you that it isn’t recognized or that it is unused. For instance, I can define an assembly:

assemblies:
  Testing123456:
    specifier: IC
    blocks:
    - name: DriverFuelBlock
      flags: FUEL
      fuel:
        shape: Circle
        material: UZr
        Tinput: 25.0
        Thot: 1500.0
        id: 0.0
        od: 0.5
        mult: 217
    height:
    - 666.0
    axial mesh points:
    - 666
    xs types:
    - B
    material modifications:
      this_is_a_fake_setting: # <--------------------------
        - 0.5

No mention of the modification this_is_a_fake_setting is made in the output. It would be useful for the user to know that their modifications are not recognized, at the very least as an input verification mechanism.

Issue Analytics

  • State:open
  • Created 2 years ago
  • Reactions:1
  • Comments:9 (8 by maintainers)

github_iconTop GitHub Comments

2reactions
davis8ddcommented, Oct 20, 2021

Is this a good first issue for someone without access to the GUI?

1reaction
john-sciencecommented, Oct 20, 2021

Is this a good first issue for someone without access to the GUI?

Yup! It looks to me like it is a bug in the code that reads blueprint files. If we can make some sort of log message happen when ingesting a blueprint with an extra config setting, that would be all we need. I might suggest to use a Warning-level log message.

And I don’t see any reason the work would involve the GUI. It should be completely unit-testable.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Material Changes - WCIRB California |
A change in ownership is material only if the owner or owners prior to the change in ownership own less than a one-half...
Read more >
Non-material Modification Definition | Law Insider
Non -material Modification means a change or amendment to the eSAS 2 Development Program other than a Material Modification.
Read more >
Summary of Benefits and Coverage and Advance Notice of ...
The Agencies define a material modification as any change to coverage that an average participant would consider important and that would affect ...
Read more >
4.3 Modifications of awards classified as equity
No. A modification to the terms of the award has not occurred because the continued vesting of the awards through November 14 pursuant...
Read more >
Hazardous Materials Markings labeling and Placarding Guide
NOTE: This document is for general guidance only and should not be used to determine compliance with 49 CFR, Parts 100-185. HAZARDOUS MATERIALS...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found