Allow for graceful container stop

Currently I see only 1 method to stop a running testcontainer: org.testcontainers.containers.GenericContainer#stop. But to my great surprise and dismay that method ends up calling dockerClient.killContainerCmd. So there is no way for graceful shutdown of running container which would allow for the application running inside it to perform any expected cleanup.

Please, provide a graceful stop.

[bsideup]

There is containerIsStopping that one can use to execute stopContainerCmd. It is also possible to stop the container externally:

container.getDockerClient().stopContainerCmd(container.getContainerId()).exec();

The default timeout of 10s should be fine in most cases. Most of containers don’t need a graceful shutdown, and it would only slow down the tests.

Also note that stopping and then starting a container won’t work properly (one of the use cases for not killing the container from stop), as Docker will assign new random ports and other state adjustments. For those who want to test what happens when the process is restarted, it is recommended to restart the process inside the container and not the container itself.

Given this, I suggest we close this issue. @rnorth @kiview WDYT?

[iNikem]

I have taken a look how easy it would be for me to propose a PR. I was unable to find a suitable place for my new proposed methods. Currently container.stop delegates directly to ResourceReaper. It would be strange if the latter was able to just stop containers, without removing them. So it seems to me that my original wish is not so easy implemented.

On the other hand, in our particular case we have found a satisfying workaround (shutting applications down via Spring Boot’s actuator), so this issue does not bother us any more at all.

As a result, I suggest just closing this issue as not relevant.