`ElasticsearchContainer` in 1.17.x does not handle `latest` tags correctly

We’re currently trying to leverage testcontainers-java with the elasticsearch module and noticed that the most recent version 1.17.1 breaks our use of the elasticsearch module. I think it’s due to this commit https://github.com/testcontainers/testcontainers-java/commit/c7449edda49ff780921067c4a03014ce68b2aa41

We’re currently trying to leverage elasticsearch version 7.4.2 but our containers fail to start with the error

org.testcontainers.containers.ContainerLaunchException: Container startup failed
Caused by: org.rnorth.ducttape.RetryCountExceededException: Retry limit hit with exception
Caused by: org.testcontainers.containers.ContainerLaunchException: Could not create/start container
Caused by: com.github.dockerjava.api.exception.NotFoundException: 
Status 404: {"message":"Could not find the file /usr/share/elasticsearch/config/certs/http_ca.crt in container df2a5216dc041fb543e4d156a05ec268f1db4cadb5efef170200b841d712b2a9"}

Please advise?

[spinscale]

This seems indeed the culprit as new ComparableVersion("latest").isGreaterThanOrEqualTo("8.0.0") returns true.

It might make sense to just log a warning, if the CA cert file is not available instead of throwing a hard exception, as the version can be anything with custom images. I’ll open a PR.

[brentryan]

is there a better way to load custom plugins and use custom images like this?

It seems like I’d want ElasticsearchContainer to have a constructor that takes a type ImageFromDockerfile and does the right thing.