Click on a disabled button with nested elements is silently ignored

• cypress-testing-library version: 2.3.5
• cypress version: 3.1.5
• node version: 8.15
• npm (or yarn) version: yarn 1.12.3

Note: This issue is related to getByText, but the problem is in the way it behaves in relation to cypress, not a bug in the actual getByText function itself.

Relevant code or config

<button disabled>
  <span>Hi</span>
</button>

What you did:

cy.getByText('Hi').click()

What happened: The span element was clicked, even though the button was disabled. The click is ignored by the button though, since it is disabled.

Workaround: You can revert to normal cypress commands and do this:

cy.contains('button', 'Hi').click();

Cypress will wait until the button is enabled before trying to click. Or if the timeout expires, it will throw an error.

Suggested solution: I’m not sure? Silently failing seems like the wrong thing though. Perhaps I just shouldn’t use cy.getByText to try to click on a button.

[NicholasBoll]

Interesting. I’ll verify later today and see if that is an issue in this library or in Testing Library DOM.

There had been many changes to this library since this issue was opened. I’ll also see if there original issue is still valid.

[kentcdodds]

Thanks for all of this! If you could open an issue for us to discuss this that would be great! It would be good to get any potentially breaking changes implemented before we cut the next major release.