Revert changes to query*s and add deprecation warning

As noted in #108, we accidentally broke the query* queries. We should restore those to the original behavior and add a deprecation warning. Let’s try to make it subtle enough to not be really annoying, but present enough to be noticed 😃

[NicholasBoll]

I know why this is happening now. I changed query* to use verifyUpcomingAssertions which will put an implicit should('exist') after the command. That works if you follow the command with an assertion - the explicit assertion changes the implicit one. If you disconnect the chain with a .then and a .wrap, the implicit assertion is in place and it doesn’t get to the .wrap. That’s true for built-in Cypress commands as well.

 // always worked
cy.queryByText('Never Exists').should('not.exist')

// Broke on the `queryByText` command since using `verifyUpcomingAssertions`
cy.queryByText('Never Exists').then(val => {
  cy.wrap(val).should('not.exist')
})

The reason the wrap worked before is because query used to return null and not fail like other commands that return DOM. This functionality might have been intentional since find* commands didn’t always retry properly. (I think that happened in 5.0).

I’m very sorry for the inconvenience. I’m glad the Cypress Testing Library find* commands work more like native Cypress commands. It makes it more natural to use in the Cypress context.

I’ll leave this issue open a bit more. Perhaps it is still safer to revert the query* line of queries. There’s a higher chance the upgrade breaks people that haven’t updated yet. Your code should be fine. The code can warn about the deprecation of query* and suggest an upgrade path

[NicholasBoll]

That must be what I was missing. It seems to be working with eventually not existing, but failing on does not exist now. I can reproduce again! Thank you!

There is a risk that reverting the change will break those relying on how 5.2 works now… 😦