Regression in getByTestId when using custom testIdAttribute v7.13.0

• @testing-library/dom version: 7.14.0 (issue appears in all versions after 7.13.0)

• Testing Framework and version:

  Jest 0.26.1

• DOM Environment:

  jsdom-environment-jsdom 0.26.1

Relevant code or config:

// setup
import * as Enzyme from 'enzyme';
import Adapter from 'enzyme-adapter-react-16';
import 'jest-enzyme';
import 'jest-extended';
import { configure } from '@testing-library/dom';
import I18n from 'utils/i18n';

Enzyme.configure({ adapter: new Adapter() });

configure({
  testIdAttribute: 'data-test',
});

I18n.locale = 'en';

What you did:

We use data-test as our test attribute for items we can’t reach by accessible handlers. After upgrading this stopped working.

What happened:

In the error output for missing nodes when we use getByTestId we see the DOM tree we expected, but testing-library fails because it can’t find an element with the same attribute value for data-testid.

Reproduction:

https://github.com/geoffharcourt/dom-testing-library-template

Problem description:

Suggested solution:

Not sure yet!

[geoffharcourt]

OK, we figured out why this is still not working. We had two versions of the package installed, and @testing-library/react was calling the old one that didn’t have the fix #651. We’re good now, thanks for your assistance investigating and for the suggestion, @smeijer!

h/t @devinrm

[smeijer]

By looking at the releases, the only thing changed in relation to the testid in 7.14 are these lines:

https://github.com/testing-library/dom-testing-library/blob/d5e17bd63c5c339d4ae29e0090f449b2c8364755/src/suggestions.js#L123:L126

To verify, they can be easily commented out. To fix, the testIdAttribute config option should be used there instead of data-testid.

I’m not sure though if/how a suggestion is able to stop queries from working.

If this is the cause, some tests should be added to cover this scenario.