should getByText return a title?

• @testing-library/dom version: latest master
• Testing Framework and version: node, jest 12.x, 26.x
• DOM Environment:

Relevant code or config:

test('foo', () => {
  renderIntoDocument(` <svg>
  <title data-testid="svg">Close</title>
  <g><path /></g>
</svg>`)

  screen.debug(screen.getByText('Close'))
})

What you did:

called screen.getByText

What happened:

I got back the title… but shouldn’t getByText be accessible to everyone? If it’s hidden, it won’t be accessible to sighted users.

Reproduction:

Problem description:

Suggested solution:

have getByText ignore <title> elements.

[kentcdodds]

This change of mind brought to you by: https://github.com/testing-library/cypress-testing-library/issues/134

In fact, the original reason for ignore was because getByText was getting me translation text that was served up in the script tag for my app when using cypress 😅 Seems it would make sense to add some other tags now that I think about it.

Anyone wanna do this?

[benmonro]

I actually am using it to check for the presence of svg so I do think we should keep it. I’m just saying it should return the element it’s a title for rather than the title element itself. Just like how get by label text will return the input element rather than the label.