Unable to find the "window" object for the given node for input event

• @testing-library/dom version: 7.28.1
• Testing Framework and version: jest 7.0.14
• DOM Environment: jsdom 16.4.0

Relevant code or config

import React from 'react';
import { createEvent, render } from '@testing-library/react';

describe('input', () => {
  it('creates an event', () => {
    const input: HTMLInputElement = render(<input />);
    const event: React.FormEvent<HTMLInputElement> = createEvent.change(input, {})
  });
});

What you did:

I ran the above test with npm test (which runs jest).

What happened:

Unable to find the "window" object for the given node. Please file an issue with the code that's causing you to see this error: https://github.com/testing-library/dom-testing-library/issues/new

Reproduction repository: https://github.com/testing-library/dom-testing-library-template

Problem description:

Suggested solution:

[mathiassoeholm]

To be clear, my suggestion is simply to change the error message from

"Unable to find the "window" object for the given node ..."

to something like

`Expected node to be a DOM Node, but got ${getTypeName(node)}`

and perhaps throw TypeError instead of Error.

The reason I mention that you’re already checking whether node is a DOM Node inside getWindowFromNode is because of:

} else if (node.ownerDocument && node.ownerDocument.defaultView) {
    // node is a DOM node
    return node.ownerDocument.defaultView

It literally says in the comment “node is a DOM node”.

I can definitely see how adding runtime type-checking to fireEvent.change itself could result in a more helpful error, but I agree on your comment about preferring static type checking and not having to maintain both.

[eps1lon]

Thanks for the report.

We should check if we’re actually given an HTMLElement because that’s not the case here. What you probably wanted to do is

-const input = render(<input />);
+const { getByRole } = render(<input />);
+const input = getByRole("textbox");
const event = createEvent.change(input, {});